Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollover failed with a reconnect after accepting renew offer #2137

Closed
holzeis opened this issue Mar 1, 2024 · 0 comments · Fixed by #2144
Closed

Rollover failed with a reconnect after accepting renew offer #2137

holzeis opened this issue Mar 1, 2024 · 0 comments · Fixed by #2144
Assignees
Labels
bug Something isn't working

Comments

@holzeis
Copy link
Contributor

holzeis commented Mar 1, 2024

Environment: test
node id: 03b48395a708073df3ece6696af2cde63bd5a39b87d3bc4f197c13dc217482d99e

  1. App gets request to rollover
  2. App rolls over
  3. Coordinator sends the RenewOffer message
  4. App accepts the RenewOffer message and transitions to RenewAccepted
  5. App disconnects and connects again
  6. Upon reconnecting the coordinator identifies that the app is in an intermediate state and rolls back to Established
Found signed channel contract in an intermediate state. Trying to rollback channel to the last stable state!
  1. Coordinator again sends a RenewOfferreferring the Established contract.
  2. App rejects rollover because it has already accepted the new contract in the RenewOffer.

Now the app is stuck and unable to move forward.

The logic for rolling back is outdated and should be removed as it has been replaced with the retry logic.

@holzeis holzeis added the bug Something isn't working label Mar 1, 2024
@holzeis holzeis changed the title Rollover failed in RenewAccepted Rollover failed with a reconnect after accepting renew offer Mar 1, 2024
@holzeis holzeis self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant