Skip to content
This repository has been archived by the owner on Sep 17, 2022. It is now read-only.

Add config LeadReader function and fix timings calculation #136

Merged
merged 3 commits into from Mar 15, 2020
Merged

Add config LeadReader function and fix timings calculation #136

merged 3 commits into from Mar 15, 2020

Conversation

dimitarvdimitrov
Copy link
Collaborator

@dimitarvdimitrov dimitarvdimitrov commented Mar 13, 2020 •
edited

Description

Add a function to load a config from an io.Reader in addition to the existing one for loading it from a file path.

The content transfer timing wasn't properly calculated

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug Fix

Checklist:

  • I have performed a self-review of my own code
  • Go code is formatted with gofmt
  • I have made corresponding changes to the docs in /docs and in the README
  • I have added tests (unit and/or end-to-end) that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published (in downstream modules)

@dimitarvdimitrov dimitarvdimitrov marked this pull request as ready for review March 14, 2020 20:32
@dimitarvdimitrov dimitarvdimitrov changed the title Add config LeadReader function Add config LeadReader function and fix timings calculation Mar 14, 2020
iv-p
iv-p approved these changes Mar 14, 2020
View reviewed changes
Copy link
Collaborator

@iv-p iv-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimitarvdimitrov dimitarvdimitrov merged commit c1e52ec into master Mar 15, 2020
@dimitarvdimitrov dimitarvdimitrov deleted the improve-config-load-api branch March 15, 2020 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iv-p iv-p iv-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dimitarvdimitrov @iv-p