New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I’m curious why we block here #70

Open

kgilpin opened this issue Dec 23, 2023 · 1 comment · May be fixed by #145

Contributor

kgilpin commented Dec 23, 2023

appmap-node/src/hooks/http.ts

Line 282 in 58cb23e

res.end(readFileSync(path));

Collaborator

dividedmind commented Dec 23, 2023

No reason, really, good catch!

zermelo-wisen linked a pull request

that will close this issue

fix: Don't block with readFileSync in remote recording finish #145

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment