Skip to content
This repository has been archived by the owner on Apr 25, 2019. It is now read-only.

Investigate vertical spacing on buttons #41

Closed
daveredfern opened this issue Jul 22, 2016 · 2 comments
Closed

Investigate vertical spacing on buttons #41

daveredfern opened this issue Jul 22, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@daveredfern
Copy link
Member

daveredfern commented Jul 22, 2016

I am generally noticing they seem to sit a little low when using default fonts. Might be something to investigate. Very noticeable when adding an SVG icon.

image

image

@daveredfern
Copy link
Member Author

This is a font issue with San Fransisco on Apple devices. I recommend not fixing it. We will only cause issues in other browsers. As @gazjoy noticed, setting to pixel values fixes the issue.

Now our default font uses system fonts we will have this issue on most sites that don't use an custom font.

Probably nothing to do here @gazjoy ?

@gazjoy gazjoy added question and removed bug labels Jul 28, 2016
@gazjoy gazjoy modified the milestones: August 2016, July 2016 Jul 28, 2016
@gazjoy
Copy link
Collaborator

gazjoy commented Jul 28, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants