Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all eslint errors and warnings #271

Closed
terror opened this issue Mar 27, 2023 · 3 comments
Closed

Fix all eslint errors and warnings #271

terror opened this issue Mar 27, 2023 · 3 comments

Comments

@terror
Copy link
Contributor

terror commented Mar 27, 2023

We're currently breaking every eslint rule in existence, it would be nice to fix that up and get eslint running in CI.

n.b. eslint --fix can do some of the work.

@boxizen
Copy link
Contributor

boxizen commented Mar 27, 2023

It would be better to add project checking and formatting before submission in the project, otherwise some irregular codes will inevitably be added later.

@terror
Copy link
Contributor Author

terror commented Mar 27, 2023

It would be better to add project checking and formatting before submission in the project, otherwise some irregular codes will inevitably be added later.

Yep that's the goal! As a prerequisite we need to fix the current state of the code base before we add a check in CI.

@truell20
Copy link
Contributor

truell20 commented Apr 8, 2023

Thanks for the prs here!

@truell20 truell20 closed this as completed Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants