Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

Use DKTL for DKAN PRs on Circle #14

Closed
dafeder opened this issue Jun 15, 2018 · 2 comments
Closed

Use DKTL for DKAN PRs on Circle #14

dafeder opened this issue Jun 15, 2018 · 2 comments
Assignees

Comments

@dafeder
Copy link
Member

dafeder commented Jun 15, 2018

This may not require any changes to dktl tool, but rather creating a bash script in dkan's .circle folder that makes the paralelization work. Perhaps a helper PHP function is needed to recreate some of the logic currently in the ruby scripts.

Acceptance criteria

  • DKTL test commands are used to run tests on circle
  • Circle paralelization logic is either in a bash script under .circle/ or in the PHP app... or take another stab at using circle 2 API?

Work

Work has been happening both in dkan-tools and in the dkan repo:
https://github.com/GetDKAN/dkan/tree/dktl-circle
https://github.com/GetDKAN/dkan-tools/tree/exit

Work Left

  1. In dkan-tools, we have some exit calls in our dktl bash script that are too early and are bypassing relevant code. We want to capture the exit code from the relevant commands and exit later with the appropriate code.
  2. In dkan, I started to work with circleci's cli-tool to parallelize our test runs, but the work is not finished, we want to be able to run both phpunit and behat tests in parallel.
@dafeder dafeder changed the title Make dktl work with circle parallelization/balancing Use dktl on circle Jun 15, 2018
@dafeder dafeder added the To Do label Jun 15, 2018
@dafeder dafeder changed the title Use dktl on circle Use DKTL for DKAN PRs on Circle Sep 11, 2018
@dafeder dafeder added the To Do label Nov 6, 2018
@kimwdavidson kimwdavidson added this to the DKAN Sprint 10 milestone Nov 26, 2018
@kimwdavidson
Copy link

Needs to be moved to DKAN repo

@woodt
Copy link
Contributor

woodt commented Mar 11, 2019

Reworked circleci config to use workflows to run the behat and unit tests in parallel; made some minor tweaks to dkan-tools so that dktl works OK in the circleci execution environment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants