Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make tables vector required for connector start #1058

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

karolisg
Copy link
Contributor

In this PR arguments of start method in connector trait changes from

 fn start(
        &self,
        last_checkpoint: Option<(u64, u64)>,
        ingestor: &Ingestor,
        tables: Option<Vec<TableInfo>>,
    ) -> Result<(), ConnectorError>;

to

 fn start(
        &self,
        last_checkpoint: Option<(u64, u64)>,
        ingestor: &Ingestor,
        tables: Vec<TableInfo>,
    ) -> Result<(), ConnectorError>;

This was done to match current dozer configuration structure, which doesn't allow running connectors without defining sources (tables).

@karolisg karolisg marked this pull request as ready for review February 26, 2023 09:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4274260879

  • 7 of 72 (9.72%) changed or added relevant lines in 20 files are covered.
  • 46 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.2%) to 72.917%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dozer-ingestion/src/connectors/ethereum/log/connector.rs 0 1 0.0%
dozer-ingestion/src/connectors/ethereum/log/sender.rs 0 1 0.0%
dozer-ingestion/src/connectors/ethereum/log/tests/helper.rs 0 1 0.0%
dozer-ingestion/src/connectors/ethereum/trace/connector.rs 0 1 0.0%
dozer-ingestion/src/connectors/ethereum/trace/tests.rs 0 1 0.0%
dozer-ingestion/src/connectors/kafka/connector.rs 0 1 0.0%
dozer-ingestion/src/connectors/kafka/test_utils.rs 0 1 0.0%
dozer-ingestion/src/connectors/postgres/test_utils.rs 0 1 0.0%
dozer-ingestion/src/connectors/postgres/tests/continue_replication_tests.rs 0 1 0.0%
dozer-ingestion/src/connectors/snowflake/tests.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
dozer-api/src/grpc/shared_impl/filter/mod.rs 1 91.89%
dozer-api/src/grpc/shared_impl/mod.rs 1 86.02%
dozer-ingestion/src/connectors/kafka/connector.rs 1 0%
dozer-ingestion/src/connectors/postgres/snapshotter.rs 1 0%
dozer-ingestion/src/connectors/snowflake/connector.rs 1 0%
dozer-api/src/grpc/typed/tests/service.rs 2 97.8%
dozer-core/src/executor/receiver_loop.rs 10 95.74%
dozer-ingestion/src/connectors/object_store/schema_helper.rs 29 51.67%
Totals Coverage Status
Change from base Build 4270817525: 0.2%
Covered Lines: 27565
Relevant Lines: 37803

💛 - Coveralls

@karolisg karolisg merged commit 9f92654 into main Feb 27, 2023
@karolisg karolisg deleted the refactor/make-tables-vector-mandatory branch February 27, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants