fix: json conversion of Decimal doesn't work with arrow-json #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcpro1
force-pushed
the
fix-sql-layer-json
branch
from
0d12403
to
dfb0157
Compare
abcpro1
force-pushed
the
fix-sql-layer-json
branch
from
dfb0157
to
cb368be
Compare
Jesse-Bakker
approved these changes
Nov 20, 2023
abcpro1
force-pushed
the
fix-sql-layer-json
branch
from
cb368be
to
dfa1454
Compare
abcpro1
force-pushed
the
fix-sql-layer-json
branch
from
dfa1454
to
1e9ff97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly serialize decimal data types, we enable the
arbitrary_precisionfeature fromserde_jsonand do our own JSON conversion fromdatafusion'sRecordBatches to JSON.