Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't retry indexing if key size is too long #2247

Merged
merged 1 commit into from Dec 5, 2023

Conversation

chubei
Copy link
Contributor

@chubei chubei commented Dec 5, 2023

The key size error used to lead to dead loop and indexing cannot make progress.

Panic message is like

ERROR panicked at dozer-cache/src/cache/lmdb/indexing.rs:226:21:
Secondary index key is too long. This usually happens with `String` fields. Try to [skip](https://getdozer.io/docs/configuration/api-endpoints#indexes) creating secondary index SortedInverted([5]).

@chubei chubei requested a review from abcpro1 December 5, 2023 14:52
@Jesse-Bakker
Copy link
Contributor

We have both String and Text types. Should we have a size restriction on String and restrict creating SortedInverted indexes to String?

@chubei
Copy link
Contributor Author

chubei commented Dec 5, 2023

We have both String and Text types. Should we have a size restriction on String and restrict creating SortedInverted indexes to String?

That would be the way to go.

@abcpro1 abcpro1 added this pull request to the merge queue Dec 5, 2023
Merged via the queue into getdozer:main with commit 85a8f31 Dec 5, 2023
5 checks passed
@chubei chubei deleted the fix/key_size branch December 6, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants