Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Make source state source wide instead of per table #2344

Merged
merged 5 commits into from Jan 24, 2024
Merged

refactor: Make source state source wide instead of per table #2344

merged 5 commits into from Jan 24, 2024

Conversation

chubei
Copy link
Contributor

@chubei chubei commented Jan 24, 2024

Part of #2342

This is one of the purposes of #2335

@chubei
Copy link
Contributor Author

chubei commented Jan 24, 2024

@karolisg I need your help to fix the mysql's encode_state and. decode_state functions.

@Jesse-Bakker
Copy link
Contributor

Can we make source state a Record instead? That would make it more easily inspectable on the sinks and every sink already knows how to write records

@chubei
Copy link
Contributor Author

chubei commented Jan 24, 2024

Can we make source state a Record instead? That would make it more easily inspectable on the sinks and every sink already knows how to write records

Good idea! I'll do that in another PR.

@chubei chubei added this pull request to the merge queue Jan 24, 2024
Merged via the queue into getdozer:main with commit c328376 Jan 24, 2024
5 checks passed
@chubei chubei deleted the refactor/state branch January 24, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jesse-Bakker Jesse-Bakker Jesse-Bakker approved these changes

Assignees
No one assigned
Labels
doc-update-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chubei @Jesse-Bakker @karolisg