refactor: Send source state and op id to sink #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chubei
force-pushed
the
refactor/id
branch
2 times, most recently
from
b279c89
to
b0a2073
Compare
Jesse-Bakker
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes in this PR:
ExecutorOperation::Op's type fromOperationtoOperationWithId, thus making the sink aware of the id that may be associated with an operation.dozer-core/src/builder_dag.rs, the sinks are built first and the sources' connection level state and op level state are read from the sink, instead of from the checkpoint. After building the source with the connection level state, the state is read from the source again and written to sink.Based on this PR, if a sink implements the writes and reads properly, it's said to be supporting resuming.
Part of #2342