Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acknowledgement responses when a command is being executed #186

Closed
mmiller1 opened this issue Dec 10, 2021 · 3 comments · Fixed by #187
Closed

Add acknowledgement responses when a command is being executed #186

mmiller1 opened this issue Dec 10, 2021 · 3 comments · Fixed by #187
Labels
enhancement New feature or request
Milestone

Comments

@mmiller1
Copy link
Contributor

something that might be cool is if gort could have a custom acknowledgement command when it is starting to execute a command in a bundle. larger container images that take time to pull on a fresh kubernetes node could leave a user questioning whether or not the command was recognized, which could lead to instances of commands being sent to gort multiple times, etc.

@theothertomelliott
Copy link
Contributor

Great idea!

I could see a few ways we could do this:

  • Post a message saying the command had been identified and was in progress, either immediately or after a delay of a few seconds without the command completing. This message could also be deleted after the command was complete.
  • Post in a thread under the original message.
  • Add a reaction to the original message. More platform specific, but both Slack and Discord support this.

@clockworksoul clockworksoul linked a pull request Jan 4, 2022 that will close this issue
@clockworksoul
Copy link
Member

Do we want to call this one complete for now and create a new issue to refine it?

@clockworksoul clockworksoul added this to the 0.9.3 milestone Jan 4, 2022
@mmiller1
Copy link
Contributor Author

mmiller1 commented Jan 4, 2022

sure, sounds great. thanks!

@mmiller1 mmiller1 closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants