Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grav 1.7 RC.6 Flex Pages UI search filter interface issue #1830

Closed
paulhibbitts opened this issue Feb 13, 2020 · 5 comments
Closed

Grav 1.7 RC.6 Flex Pages UI search filter interface issue #1830

paulhibbitts opened this issue Feb 13, 2020 · 5 comments
Assignees

Comments

@paulhibbitts
Copy link
Contributor

paulhibbitts commented Feb 13, 2020

The new search/filter feature for Grav Flex pages is fantastic! I've been trying it out, and notice that the interface unexpectedly partially scrolls up when you Apply Filters, as shown below:

2020-02-13_13-31-24 (1)

I'd tend to expect that either the search/filter panel disappears and the filtered results are fully shown (preferred )OR the panel remains exactly in the same place for manual closing.

Please let me know if any additional info/testing is helpful.

Thanks very much,
Paul

@mahagr
Copy link
Member

mahagr commented Feb 13, 2020

@w00fz Can you take a look?

@w00fz
Copy link
Member

w00fz commented Feb 13, 2020

@paulhibbitts from what I’m seeing from your gif , that seems to be happening because when you start off filtering, the height of the page is greater than the height of the page after filtering. That causes the page to shift automatically to adjust for compensating to the shortening of the new height.

Try filtering by published, you’ll probably see the shifting doesn’t happen anymore

@paulhibbitts
Copy link
Contributor Author

Thanks for looking @w00fz , but that also seems to have the same issue:
2020-02-13_15-11-16 (1)

You can download the skeleton shown above at https://1drv.ms/u/s!Aoj9Cstt0NJ0kt4VMZlY6H_Z7yLAnA?e=PZQ1Ld

What do you think of closing the filters panel once "Apply Filters" is tapped to then fully show the updated page list for navigation etc?

@rhukster rhukster added the ui label Feb 24, 2020
@w00fz
Copy link
Member

w00fz commented Mar 6, 2020

Fixed in trilbymedia/grav-plugin-flex-objects@8d9d3aa .

This was an odd behavior I had to work around caused by the custom gemini scrollbars that we use throughout the whole admin which are not always so friendly.

Should be all good now, filters remain open but nothing jumps around causing dizziness.

@w00fz w00fz closed this as completed Mar 6, 2020
@paulhibbitts
Copy link
Contributor Author

Thanks very much @w00fz ! Looking forward to trying this out🙂

@mahagr mahagr added the 1.10 label Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants