Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen mode in Grav v1.7.14 - Admin v1.10.14 not honoring left side panel #2143

Closed
fseesink opened this issue May 6, 2021 · 3 comments
Closed

Comments

@fseesink
Copy link

fseesink commented May 6, 2021

This was working when I first started using Grav (not long ago). At the time I believe it was Grav v1.7.10. Back then when I tried fullscreen mode, it worked flawlessly. And I loved it.

But somewhere along the way things changed. Not sure if it's Grav, Admin, Firefox, or what. But with the current version of Grav and Admin, the fullscreen mode in the editor doesn't honor the left-side panel space. That is... here, here's two pictures to show what I mean:

First, there's the regular editor:
image

Then there's what you see when you click the fullscreen button in the upper right:
image

Note how the editor window ends up behind the left panel, so you can't see all the text.

This is using Firefox v88.0.1 on macOS 10.15.7 "Catalina" (all patches applied). I see similar behavior in Safari (Version 14.1 (15611.1.21.161.5, 15611)).

And collapsing the left-side panel is not enough, as there's still a small portion of the edit window that ends up underneath.

If you need anything else from me, let me know.

@rhukster
Copy link
Member

rhukster commented May 6, 2021

This is a classic case of me fixing one thing, that breaks another, then fixing that and it breaks the original issue. I think I have a solution that solves this and the last issue that I fixed that caused this. So crossing fingers there's no other issues that turn up related to this :)

@paulhibbitts
Copy link
Contributor

@rhukster LOL, you just summed up my usual development process with "fixing one thing, that breaks another, then fixing that and it breaks the original issue" 😉

@fseesink
Copy link
Author

fseesink commented May 8, 2021

Boy does that sound all too familiar. Don't know if it has a name, but much like The Prisoner's Dilemma, it should just be called The Programmers Dilemma. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants