Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed not loading after upgrading to 1.8.3 #62

Closed
doryiii opened this issue Jun 2, 2021 · 17 comments
Closed

Feed not loading after upgrading to 1.8.3 #62

doryiii opened this issue Jun 2, 2021 · 17 comments

Comments

@doryiii
Copy link

doryiii commented Jun 2, 2021

I don't recall what the last version was, but I recalled it was working back in Sep 2020.

After upgrading to grav 1.7.15 and feed 1.8.3, the feed URLs no longer works. Before, going to https://bakkin.moe/home.rss would load the RSS feed for the home blog content; however, now it just brings up the actual blog HTML page.

No config has been changed since June 2020, including during the recent upgrade.

@rhukster
Copy link
Member

rhukster commented Jun 2, 2021

Are you sure you are on Feed v1.8.3? That has a fix that specifically addresses the issue you are describing.

if so, then could I get a copy of your homepage .md file? Perhaps it has a different configuration I'm not taking into account. Cheers.

@doryiii
Copy link
Author

doryiii commented Jun 2, 2021

Yes, I am running Feed v1.8.3
image

my user/pages/01.home/blog.md:

---
title: Home
visible: true
content:
    items: '@self.children'
    order:
        by: date
        dir: desc
    limit: 10
    pagination: true
    filter:
        visible: true
annewsment:
    items:
        -
            '@page.self': /annewsment
    filter:
        visible: true
---

@Sasumotu
Copy link

Sasumotu commented Jun 3, 2021

Got the same problem since 1.8.2. 1.8.3 also didn't fix it for me.

frontpage.md:

---
title: Home
sitemap:
    changefreq: monthly
content:
    items: '@self.children'
    order:
        by: date
        dir: desc
    limit: 5
    pagination: true
feed:
    limit: 10
pagination: true
cache_enable: false
---

@rhukster
Copy link
Member

rhukster commented Jun 3, 2021

can you guys send me a zip of a test setup where this happens for you? I can't replicate it with my setups

@Sasumotu
Copy link

Sasumotu commented Jun 4, 2021

I tried to reproduce it in a local LAMP environment with my website but there everything worked fine.

So I started suspecting that it is some kind of problem with my shared hosting provider. They are using apache2 with nginx as a reverse proxy as the default setup. If I disable nginx and all requests are served via apache2 the rss feed is working as expected.

@utagawal
Copy link

utagawal commented Jun 4, 2021

Hello,

Same behavior here, the rss page doesn't load anylonger, instead it shows the html page.

You can check on https://blog.utagawavtt.com and https://blog.utagawavtt.com/fr/blog.rss

@doryiii
Copy link
Author

doryiii commented Jun 4, 2021

I'll set up a test instance when I get home and send that over if I can reproduce the issue over there.

@rhukster
Copy link
Member

rhukster commented Jun 7, 2021

@utagawal https://blog.utagawavtt.com/fr/blog.rss is totally showing the RSS feed output.

<? xml version = "1.0" encoding = "utf-8"?>
<rss xmlns: atom = "http://www.w3.org/2005/Atom" version = "2.0">
    <channel>
        <title> UtagawaVTT - Articles </title>
        <link> https://blog.utagawavtt.com/en </link>
        <atom: link href = "https://blog.utagawavtt.com/fr/blog.rss" rel = "self" type = "application / rss + xml" />
        <description> The latest posts from the UtagawaVtt blog </description>
        <language> en </language>
        <lastBuildDate> Sat, 05 Jun 2021 11:50:00 +0200 </lastBuildDate>
                        <item>
            <title> The top GPS connected watches for mountain biking </title>
            <link> https://blog.utagawavtt.com/fr/blog/top-montres-gps </link>
            <guid> https://blog.utagawavtt.com/fr/blog/top-montres-gps </guid>
            <pubDate> Sat, 05 Jun 2021 11:50:00 +0200 </pubDate>
            <description>
                <! [CDATA [
                                <img alt = "" src = "https://blog.utagawavtt.com/images/7/4/4/0/8/74408c65a359cce94a424b84723e0ce27662b96c-suunto-9-mtb.jpg" />
                                <p> <span class = "dropcaps dropcaps-c"> C </span> choose a GPS watch for mountain biking without making a mistake? </p>
<p> With their large color screens (sometimes with even full mapping), their functionality and all the sensors that can be paired with them, some GPS watches can now largely take the place. ; a mountain bike GPS and / or bicycle computer. </p>
<p> However, ... </p>
....

@utagawal
Copy link

utagawal commented Jun 7, 2021 via email

@rhukster
Copy link
Member

rhukster commented Jun 7, 2021

I just released a new 1.8.4 version that has better matching support for multilang. I've also added a new enable_url_check to the config so that can be turned off in a pinch. The new matching logic should be better for all conditions and I tested it with a variety of setups. This check ensures that the RSS logic is not processed unless it needs to be. It will provide a performance improvement to all pages so it's worthwhile getting it working.

@utagawal
Copy link

utagawal commented Jun 8, 2021 via email

@rhukster
Copy link
Member

rhukster commented Jun 8, 2021

You can also try the disabling of that enabled_url_check option

@rhukster
Copy link
Member

rhukster commented Jun 8, 2021

BTW, just checked on my local multilang blog setup, and /.rss + /blog.rss work for default lang (en), fr/.rss +fr/blog.rss work for french.

en/.rss and en/blog.rss don't work because I have include_default_lang set to false. If i set this value to true, then those do work.

This is as expected.

@rhukster
Copy link
Member

rhukster commented Jun 9, 2021

I've decided to roll back this 'checking' functionality as it really doesn't add much at this point, and causes more issues than it solves. 1.8.5 should be good.

@rhukster rhukster closed this as completed Jun 9, 2021
@jgonyea
Copy link
Contributor

jgonyea commented Sep 18, 2021

Can we reopen this? I think 1.8.5 still has this issue. I rolled back to 1.8.0 and the RSS feed displayed as expected (I'm using a custom feed.rss.twig file via the podcast plugin), but 1.8.5 just renders the html page.

@jgonyea
Copy link
Contributor

jgonyea commented Sep 18, 2021

When I "git bisect", the issue arises from the "bad" commit 52ddd0d :
"fixed issue with json feed type corrupting other json requests getgrav/grav-premium-issues#102"

@jgonyea
Copy link
Contributor

jgonyea commented Sep 18, 2021

Happy to provide a zip of my example pages, if you need it @rhukster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants