Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NONCE_NOT_VALIDATED message needs revision #513

Closed
aricooperdavis opened this issue Mar 17, 2021 · 2 comments
Closed

NONCE_NOT_VALIDATED message needs revision #513

aricooperdavis opened this issue Mar 17, 2021 · 2 comments
Assignees

Comments

@aricooperdavis
Copy link

The NONCE_NOT_VALIDATED message is currently:

"Oops there was a problem, please check your input and submit the form again."

This advice doesn't work if the form was submitted via AJAX as the form nonce won't have changed so resubmitting the form will cause the same error. I'm not even convinced that the form nonce changes if the form is POSTed normally, but haven't experimented with this. I suggest we revise this message to something like:

"Oops, your form has timed out, please reload the page and submit the form again."

As this prompts the user to reload the page, thereby regenerating the forms unique ID.

@mahagr
Copy link
Member

mahagr commented Mar 18, 2021

I like the proposal as it tells what really happened (regardless of AJAX or not).

@rhukster
Copy link
Member

I agree, that's a better message, more accurate and useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants