Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content of Taxonomy field should not be translated #534

Open
pamtbaau opened this issue Sep 25, 2021 · 0 comments
Open

Content of Taxonomy field should not be translated #534

pamtbaau opened this issue Sep 25, 2021 · 0 comments

Comments

@pamtbaau
Copy link

pamtbaau commented Sep 25, 2021

Bug/Suggestion: Values for Taxonomy field should not be translated.

Why:

  • Taxonomy values in page headers are taken literally and are not translated by Grav, Quark or eg. the TaxonomyList plugin.

  • However, Taxonomy values are being translated by Form plugin when displayed in Admin. This has two side effects:

    • When user enters any value which is a top-level string value in any translation file, it gets translated in Admin after saving. This might be confusing behaviour to the user.
      The value in page header remains correct though when saving again.
    • If value entered by user is a top-level array value, error "Array to string conversion" at /user/plugins/form/templates/forms/fields/select/select.html.twigL65 is being thrown in Admin

Reproduce:

  • Create new page (with editor or Admin) and add taxonomy value GRAV
---
title: 'This is a test page'
taxonomy:
    tag:
        - TYPO3
        - WordPress
        - GRAV
---
  • Open page in Admin
  • Error is being thrown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant