New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin form v 2.0.1 breaks modular 'action' field processing #91
Comments
Mmm, looks like a regression! What's your modular form definition, can you paste it here and I'll check? You read this https://learn.getgrav.org/forms/forms#modular-forms, right? Modular forms should work if defined in the modular child itself, no config involved. |
Just tested again, works fine to me |
Hello! Thanks for replying so quickly. I've also tried moving the form directly to modular child with no success at all. If I remove the 'action' field (was set as 'contact)', logically it takes the @self value of the module (eg. /contact/_childmodule) but hits an 404. ¿Something related to routes? I'm using a customized theme from getgrav.org (Deliver) but the form is just the original from that theme (except for labels). https://demo.getgrav.org/deliver-skeleton/contact Contact page at demo seems to work fine. But I've just downloaded full fresh skeleton package for deliver theme to test it at local php server. Not working anymore. Forms is already v2.0.1 in that package. Same behaviour. Thanks again and have a great day! |
Mmm, reproduced the issue on the Deliver skeleton. Looking into it. |
Traced it to getgrav/grav-theme-deliver@6ff958b - can you simply remove the forms/ folder in the Deliver twig templates, and check if now it works? |
Hello Flavio, you found it. Form now works flawlessly. I wish I could have been of more help. Thanks for your time and work at Grav! Really really appreciated ;) |
Ok good! We can do a release today |
Hi,
I've just updated Form to v2.0.1 in a Grav website and contact form stopped working. It reloads itself with no form processing at all. Reverting back to v1.3.2 fixes the issue. Removing or setting an incorrect 'action' field and value in frontmatter gets a 404. I've seen in Grav documentation that Forms 2.0 allows to define form code directly to modular page instead of parent page. Guess there's some config involved but can't figure out what have changed.
Thanks in advance for your time.
The text was updated successfully, but these errors were encountered: