-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images support #15
Comments
The plugin provides a very basic output in its own Twig file (https://github.com/getgrav/grav-plugin-langswitcher/blob/develop/templates/partials/langswitcher.html.twig). The theme can decide to override that, and provide flags or other types of output, by adding a |
Pics and flags in the langswitcher should be implemented as a core plugin feature. It is just my personal approach. I also understand that this is at the moment a no priority thing if i compare importance with other workplaces in grav and gantry. |
Open for a PR if someone wants to add this functionality. |
Hi, im agree with Neuronauten that Pics and flags in the langswitcher should be implemented as a core plugin feature.
Reasons why that must be in the plugin:
|
PRs please :) |
english is not my native languadge, please describe, what "PRs" means? |
PR = Pull Request |
Hi, |
While I have nothing against people adding options and am aware that this is not always the dev's choice, I'd like to suggest that those wanting flags (or those who may develop the functionality for the PR) check out this article. It does an excellent job of explaining why flags are not always (except in a pretty specific case) appropriate. As an:
|
cleaning up old tickets... |
Would it be possible to implement images support ? Without images support the langswitcher plugin feels spoon-feeding to use text only. The flags lovers and the icon user are left out. Explicitly new ideas about language suggestion are left out also.
The text was updated successfully, but these errors were encountered: