Add form name to the register template page

[Chessmasterrr]

Added a "name" tag for the form on the register template page, since the form isn't displayed without this name tag. This behaviour is in place since Forms 2.0, see: https://learn.getgrav.org/forms/forms

[flaviocopes]

Hi, I see a problem with Form 2.0 and the registration form, but this PR does not fix it yet. Looking at it now.

[flaviocopes]

Just pushed a fix in the Login plugin, plus this PR in the Form plugin getgrav/grav-plugin-form#101 to fix the issue. If you could test both, would be great!

[Chessmasterrr]

I have tried to test it, but it doesn't fix the problem (or I am doing it wrong?). I have done the following:

• Installed a new version of grav (version 1.1.8 from https://getgrav.org/downloads)
• Get your fix from here: https://github.com/getgrav/grav-plugin-form/tree/feature/registration-form
• Deleted all files and folders in user/plugins/form/ and copied all files from your fix to that location.
• Enabled in the admin backend under "plugins" the user registration and set "/register" as registration path.
• Called domain.tld/register, but I only see the "Register" heading, without any form elements.

And you are right, I have tested now also my fix with the name tag in the new installation and it isn't working, sorry for that. Don't know, what other changes I've done a few weeks ago to get it running.

If I create an own page with "form"-type and insert the frontmatter of the registration page, I see a correct page with form. So maybe he isn't interpreting the register page as a "form", but I didn't know how to force him to.

[flaviocopes]

Also update the Login plugin, the Form update fixes a problem in submitting the form, while the form appearance is fixed in the Login plugin. Sorry for the confusion!

[Chessmasterrr]

Ah, sorry, I didn't see your commit to the login plugin, my fault. Now I tested it additionally with the updated login plugin (from here: https://github.com/getgrav/grav-plugin-login/tree/82da8a6f4aa4eb658fb3c69c792f92e287bf04a1), but I get the following error, when I access the site (and get redirected to the admin-backend to create an admin user):

 Twig_Error_Runtime
 An exception has been thrown during the rendering of a template ("Identifier "messages" is not defined.") in "partials/messages.html.twig" at line 1.

If you need more information on this (or I am still doing it wrong), let me know.

[flaviocopes]

Ah I see, it's caused by a recent update of Login/Admin, where we moved the messages capability from Login to Admin. Also update the Admin plugin to the latest develop. Seems hard to test this one! :)

[rhukster]

Pretty sure I recently moved this into grav core actuallly. Which change are you referring to @flaviocopes ?

[flaviocopes]

Oh right it was moved into core Grav, not Admin, sorry.

Updating Login without updating Grav to the latest is going to cause that messages template missing error.

[Chessmasterrr]

I'm sorry, but I'm not able to test the current develop branch from Grav, since I have no terminal access on my server (only pushing files via ftp).

As a workaround I will use a manually created form-page to register new users and will wait until your changes are in the next release. Thanks for your fast response to the problem!

Since my solution in this pull request is not helping, I will close it.