Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size SC with named & other units #62

Closed
finanalyst opened this issue Mar 5, 2019 · 1 comment
Closed

Size SC with named & other units #62

finanalyst opened this issue Mar 5, 2019 · 1 comment

Comments

@finanalyst
Copy link
Contributor

finanalyst commented Mar 5, 2019 •
edited

CSS allows for the font-size attribute to have values such as x-large, and units such as pt or %.

Current implementation of [size=...] sticks px onto the parameter. This reduces flexibility.

Suggest change so that px is concatenated to parameter value only when parameter is a number.

See PR #63
@rhukster
Copy link
Member

Merged.. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@finanalyst @rhukster