Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the page from which to get the child tags #39

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

aleclerc7
Copy link
Contributor

Hello,

A very small suggestion to give the possibility to specify which page’s child tags one wants.

  • This is very useful when many "blogs" are used on a site to have contextualized tags.
  • Fully backward compatible.
  • No fuss, no clutter, a single new optional parameter when calling the template. (I guess one could change its name; I do not know if there are naming standards.)
  • README.md has been updated to add the information.

Kind regards.

A very small suggestion to give the possibility to specify which page’s child tags one wants. This is very useful when many "blogs" are used on a site.
Copy link
Member

@mahagr mahagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mahagr mahagr requested a review from rhukster March 17, 2022 08:05
@aleclerc7
Copy link
Contributor Author

If you have a minute @rhukster, even if there is no plugin release, it would be nice to have this change approved.
At least it will be there. :-) Kind regards.

@jovaniedelacruz
Copy link

@rhukster I'm looking forward to this PR getting approved! This feature works well for me when I manually install. Can't wait for it to be released in gpm.

@rhukster rhukster merged commit 0bced9f into getgrav:develop Apr 8, 2024
@rhukster
Copy link
Member

rhukster commented Apr 8, 2024

Looks good, not sure how i missed it.

@aleclerc7 aleclerc7 deleted the specific-page-child-tags branch April 8, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants