Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home menu item not going anywhere #3

Closed
spacemonkey opened this issue Oct 15, 2015 · 3 comments
Closed

Home menu item not going anywhere #3

spacemonkey opened this issue Oct 15, 2015 · 3 comments

Comments

@spacemonkey
Copy link

Just installed the skeleton and the Home item in the menu doesn't go anywhere. All of the other menu items appear to work fine though.

Trying with:

  • Chrome Version 46.0.2490.71 (64-bit)
  • Safari Version 9.0 (10601.1.56.2)
@rhukster
Copy link
Member

This is actually from the theme:

https://github.com/getgrav/grav-theme-hpstr/blob/develop/templates/partials/navigation.html.twig#L4

can you try changing this line to:

<li><a href="{{ base_url_relative ?: '/' }}">Home</a></li>

@spacemonkey
Copy link
Author

That was the issue, your fix passes - you got this from here?

@rhukster
Copy link
Member

Sure, in the future a PR would be helpful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants