Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http endpoints in css instead of protocol relative // #7

Open
byrge opened this issue Jul 18, 2016 · 3 comments
Open

http endpoints in css instead of protocol relative // #7

byrge opened this issue Jul 18, 2016 · 3 comments

Comments

@byrge
Copy link

byrge commented Jul 18, 2016

Hi, a small issue with the Landio skeleton is the use of the http protocol to load the social endpoints. Better use the protocol relative // instead. So for example change —'http://graph.facebook.com/…' to —'//graph.facebook.com/…'. The same for the other http endpoints in the css

@rhukster
Copy link
Member

Please edit the files on github.com and click the green "create pull request" button.

@flaviocopes
Copy link
Contributor

P.S. the best thing now should be to use https directly instead of a protocol-independent URL, as even on http-based sites it's best to load external resources via https

@byrge
Copy link
Author

byrge commented Jul 19, 2016

I can't find it. It's in templates / partials / header.html.twig:

  <script type="text/javascript">
        {% if site.socialcount.facebook_url %}
        // Facebook Shares Count
        $.getJSON( '//graph.facebook.com/?id={{ site.socialcount.url }}', function( fbdata ) {
            $('#facebook-count').text(fbdata.shares)
        });
    {% endif %}

And for the other social networks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants