Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modular page error #1771

Closed
JohnMica opened this issue Dec 3, 2017 · 3 comments
Closed

modular page error #1771

JohnMica opened this issue Dec 3, 2017 · 3 comments

Comments

@JohnMica
Copy link

JohnMica commented Dec 3, 2017

I got an interesting one here, that i can reproduce on local dev with plain grav and admin / antimatter theme - all the latest.

  • create a modular page
  • create / or not empty children of the modular page
  • try to view the page in the browser and get an error as per the image
    captura de ecran din 2017 12 03 la 13 41 11

Not sure if this is due to no information present on the page itself but as soon as I add some text, the error is gone.

Also, once the Modular page is created, the only way to add text is to use the advanced mode (not sure if this is the intended behaviour), as per the image
captura de ecran din 2017 12 03 la 13 45 28

just thought you might want to know about this

@rhukster
Copy link
Member

rhukster commented Dec 4, 2017

Well your error is clearing coming from image-captions plugin, so probably it's trying to do work on empty content, hence throwing the error.

Can you try editing the image-captions.php with this check:

    protected function processFigures($content)
    {

        if (trim($content) === '') {
            return;
        }
...

@JohnMica
Copy link
Author

JohnMica commented Dec 4, 2017

Thanks Andy. I’ll update that and see what happens. I might disable the plugin all together for now.

@JohnMica
Copy link
Author

update - it seems the disabling /removing of the image-captions plugin did the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants