Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grav 1.7 RC6 Unexpected difference in Flex Page creation via Admin #2823

Closed
paulhibbitts opened this issue Feb 12, 2020 · 4 comments
Closed
Assignees

Comments

@paulhibbitts
Copy link

paulhibbitts commented Feb 12, 2020

I've noticed that using the same page creation blueprints in Admin produces a different (and unexpected) result in Flex Pages front-end enabled:

Non-Flex pages:
2020-02-12_13-56-05

2020-02-12_13-56-24

2020-02-12_13-56-36

2020-02-12_15-34-17

The above is expected behaviour, with the new page visible in the menu.

Flex pages:
2020-02-12_13-57-22

2020-02-12_13-57-45

2020-02-12_13-58-07

2020-02-12_15-33-45

Here is the page creation blueprint used for both:
https://github.com/hibbitts-design/grav-skeleton-course-hub/blob/master/blueprints/admin/pages/new_page.yaml

Any thoughts? Happy to share more info/do more tests if helpful.
Paul

@mahagr
Copy link
Member

mahagr commented Feb 13, 2020

Your blueprint says visible = not set, so yeah, I think that the old behaviour was to make it visible in that case. I still think it would be better to set visible to 1 or 0 instead, but I will take a look on this.

@paulhibbitts
Copy link
Author

Thanks @mahagr , I've done more testing and this also seems to change the behaviour of the standard "Add Page" dialog when adding a page to the root with "Auto" visibility. This used to create a number folder page, but now it does not.

@mahagr
Copy link
Member

mahagr commented Mar 3, 2020

Fixed in flex plugin: trilbymedia/grav-plugin-flex-objects@c8f1ce2

@paulhibbitts
Copy link
Author

Thanks very much @mahagr !

@mahagr mahagr closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants