Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space in session name throws cookie error #952

Closed
Potolozi opened this issue Jul 21, 2016 · 1 comment
Closed

Space in session name throws cookie error #952

Potolozi opened this issue Jul 21, 2016 · 1 comment
Labels

Comments

@Potolozi
Copy link

Potolozi commented Jul 21, 2016

In the site.yaml where the session name can be configured, if the session name contains a space a cookie error is thrown when trying to initiate the session. There is also a field in the Admin Plugin>Configuration where this value is set by the user. The error "Cookie names cannot contain any of the following '=,; \t\r\n\013\014'" is thrown. This is easily replicated.

It would be logical to expect from a user not to introduce other characters in the session name, but it is not immediately apparent to the user that this error is due to the space in the session name. The user may think that the session name could be his site name since the default session name is "grav-site".

Either there has to be a strong warning that no spaces are allowed or spaces need to be converted into a different character.

@rhukster rhukster added the bug label Jul 22, 2016
@rhukster
Copy link
Member

Sounds like we need to hypenize the session name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants