-
-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Minor Quick Launch issues #1395
Comments
1 I can confirm, though annoyingly I had already fixed that so this is some kind of regression. Anyway, I cant reproduce the second one and that would not be a minor bug. That would mean any time you type a letter thats contained in name + description it would show duplicates. Can you try re-creating your container and see if that persists. See this, no dupes: |
Thanks for the quick reply. I recreated the container and got the same result on #2, but I narrowed down the STR. This is the initial set of results after entering "sync" on a fresh load of the page. The two duplicated instances are Docker containers, the one that isn't duplicated is a direct install without a container reference in services.yaml. Then while the floating search box was still open, I did a select-all and re-entered the same query. The duplicated instances then appeared 4x each instead of 2x. Another Ctrl-A and the duplicates appeared 6x, then 8x, etc. It's a bit of an edge case, I don't know how many users would edit their search terms instead of dismissing and re-invoking the search box. Can you reproduce? |
A few more details - in addition to being named Syncthing, all my Syncthing instances have the widget configured, and the Docker containers are also named syncthing. |
Ah, so your |
Hmm, so every service should have a unique name, whether specified in services.yaml or a Docker label? I'm not using Docker auto discovery, but I do have 3 services all named Syncthing in services.yaml. I also have multiple entries named Portainer and Watchtower, but only Portainer as a search term generates odd results, as below. (Also not sure why one of the Syncthing entries would appear in search results for Portainer...) |
Correct they should be unique. Im going to push a change that will circumvent the duplication error but again you should give them unique names, it can cause other issues. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Description
Thank you for publishing this code! It's the cleanest and most functional homelab dashboard I have found.
In tweaking my config I noticed two minor issues with the Quick Launch feature:
Every result is categorized as Bookmark (I assume services should appear as Service).
Results are not de-duplicated. For a single service where the query string may match the title, description, Docker container, and widget type, multiple results seem to be generated. The number of results shown for the same query string may vary on consecutive queries.
Nothing in logs for either of the above. Please let me know if I can provide other info.
Steps to reproduce
Set quicklaunch: searchDescriptions to true in settings.yaml. Open the homepage URL and begin typing.
homepage version
0.6.16
Installation method
Docker
Configuration
No response
Container Logs
No response
Browser Logs
No response
Other
No response
Before submitting, I have made sure to
The text was updated successfully, but these errors were encountered: