Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Minor Quick Launch issues #1395

Closed
3 tasks done
mwhdc opened this issue Apr 21, 2023 · 7 comments · Fixed by #1397
Closed
3 tasks done

[Bug] Minor Quick Launch issues #1395

mwhdc opened this issue Apr 21, 2023 · 7 comments · Fixed by #1397
Labels
bug Something isn't working

Comments

@mwhdc
Copy link

mwhdc commented Apr 21, 2023

Description

Thank you for publishing this code! It's the cleanest and most functional homelab dashboard I have found.

In tweaking my config I noticed two minor issues with the Quick Launch feature:

  1. Every result is categorized as Bookmark (I assume services should appear as Service).

  2. Results are not de-duplicated. For a single service where the query string may match the title, description, Docker container, and widget type, multiple results seem to be generated. The number of results shown for the same query string may vary on consecutive queries.

Quick Launch

Nothing in logs for either of the above. Please let me know if I can provide other info.

Steps to reproduce

Set quicklaunch: searchDescriptions to true in settings.yaml. Open the homepage URL and begin typing.

homepage version

0.6.16

Installation method

Docker

Configuration

No response

Container Logs

No response

Browser Logs

No response

Other

No response

Before submitting, I have made sure to

@mwhdc mwhdc added the bug Something isn't working label Apr 21, 2023
@shamoon
Copy link
Collaborator

shamoon commented Apr 21, 2023

1 I can confirm, though annoyingly I had already fixed that so this is some kind of regression. Anyway, I cant reproduce the second one and that would not be a minor bug. That would mean any time you type a letter thats contained in name + description it would show duplicates. Can you try re-creating your container and see if that persists. See this, no dupes:

Screenshot 2023-04-21 at 8 58 36 AM

Screenshot 2023-04-21 at 8 56 37 AM

@mwhdc
Copy link
Author

mwhdc commented Apr 21, 2023

Thanks for the quick reply. I recreated the container and got the same result on #2, but I narrowed down the STR.

This is the initial set of results after entering "sync" on a fresh load of the page. The two duplicated instances are Docker containers, the one that isn't duplicated is a direct install without a container reference in services.yaml.

1

Then while the floating search box was still open, I did a select-all and re-entered the same query. The duplicated instances then appeared 4x each instead of 2x. Another Ctrl-A and the duplicates appeared 6x, then 8x, etc.

2

It's a bit of an edge case, I don't know how many users would edit their search terms instead of dismissing and re-invoking the search box. Can you reproduce?

@mwhdc
Copy link
Author

mwhdc commented Apr 21, 2023

A few more details - in addition to being named Syncthing, all my Syncthing instances have the widget configured, and the Docker containers are also named syncthing.

@shamoon
Copy link
Collaborator

shamoon commented Apr 21, 2023

Ah, so your - homepage.name=Syncthing for all these? Don't do that, they should be unique, like "Synching Pi2", "Synching Syn" etc. You also probably do have an error in your browser if youre doing that

@mwhdc
Copy link
Author

mwhdc commented Apr 22, 2023

Hmm, so every service should have a unique name, whether specified in services.yaml or a Docker label? I'm not using Docker auto discovery, but I do have 3 services all named Syncthing in services.yaml. I also have multiple entries named Portainer and Watchtower, but only Portainer as a search term generates odd results, as below. (Also not sure why one of the Syncthing entries would appear in search results for Portainer...)

1

2

@shamoon
Copy link
Collaborator

shamoon commented Apr 22, 2023

Correct they should be unique. Im going to push a change that will circumvent the duplication error but again you should give them unique names, it can cause other issues.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants