Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Pihole widget leaks auth token in API error messages #3384

Closed
2 tasks done
Nospamas opened this issue Apr 29, 2024 · 1 comment · Fixed by #3385
Closed
2 tasks done

[Bug] Pihole widget leaks auth token in API error messages #3384

Nospamas opened this issue Apr 29, 2024 · 1 comment · Fixed by #3385
Labels
bug Something isn't working

Comments

@Nospamas
Copy link

Nospamas commented Apr 29, 2024

Before submitting, please confirm the following

  • I confirm this was discussed, and the maintainers suggest I open an issue (note that AI bots are not maintainers).
  • I am aware that if I create this issue without a discussion, it will be removed without a response.

Discussion Link

#3383

Additional context

When displaying API errors in homepage the full auth token is revealed due to it being passed as a query string.

Example error from homepage widget (auth token obfuscated):


    API Error: Unknown error
    URL: https://pihole2.cansk.net/admin/api.php?summaryRaw&auth=****
    Raw Error:
    {
        "code": "ECONNREFUSED"
    }
@Nospamas Nospamas added the bug Something isn't working label Apr 29, 2024
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant