Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Search Provider Errors [Bug] #524

Closed
angryviking opened this issue Nov 17, 2022 · 2 comments
Closed

Custom Search Provider Errors [Bug] #524

angryviking opened this issue Nov 17, 2022 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@angryviking
Copy link

Description

When provisioning a custom search provider, I get redirected to an undefined URL, with "Application error: a client side exception has occurred"

URL bar after searching for "test" using a custom provider:
image

The predefined providers like Google seem to work fine.

Some of the custom search providers I have tried in my settings file:

- search:
    provider: custom
    url: https://google.com/search?q=
    target: _blank
    
- search:
    provider: custom
    url: https://search.brave.com/search?q=
    target: _blank

- search:
    provider: custom
    url: https://themoviedb.org/search?query=
    target: _blank

These URLs all work fine from the browser and the homepage container can ping the domains.

# docker exec homepage ping themoviedb.org
PING themoviedb.org (108.156.83.71): 56 data bytes
64 bytes from 108.156.83.71: seq=0 ttl=247 time=9.828 ms
64 bytes from 108.156.83.71: seq=1 ttl=247 time=9.913 ms
64 bytes from 108.156.83.71: seq=2 ttl=247 time=9.859 ms
^C
# docker exec homepage ping search.brave.com
PING search.brave.com (13.226.52.94): 56 data bytes
64 bytes from 13.226.52.94: seq=0 ttl=245 time=9.994 ms
64 bytes from 13.226.52.94: seq=1 ttl=245 time=10.609 ms
^C

The custom search used to work, but that could have been in an earlier version of homepage.

Also, as an enhancement, it would be nice to be able to change the text in the search bar from "Search..." to something custom like the provider name. That way if I have multiple search bars (like adding themoviedb search to just search for movies) I would know which provider that I am using.

Steps to reproduce

  1. Add a custom search provider in the widgets.yaml file, like
- search:
    provider: custom
    url: https://google.com/search?q=
    target: _blank
  1. Go to the local homepage in the browser

  2. Try to search; example for "test" and click the search icon
    image

homepage version

v0.4.18 (4ea2798, Oct 15, 2022)

Installation method

Docker

Configuration

No response

Other

No response

@angryviking angryviking added the bug Something isn't working label Nov 17, 2022
@shamoon
Copy link
Collaborator

shamoon commented Nov 17, 2022

Please see #506 , #446, #423, fixed by #430

@shamoon shamoon closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2022
@shamoon shamoon added the duplicate This issue or pull request already exists label Nov 17, 2022
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants