Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] favicon.ico will not apply from local store, but does apply the same ico from web source #595

Closed
TopCheddar27 opened this issue Dec 1, 2022 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@TopCheddar27
Copy link

TopCheddar27 commented Dec 1, 2022

Description

While customizing the favicon in settings, locally stored .ico files in the /app/public/images folder will not apply. However, when referencing the same .ico file from the web source, it applies just fine. First, I thought it could be permissions or storage location. However, background images sourced from the same /app/public/images folder with the exact same permissions apply just fine. I have also browsed locally in the container to confirm that the file is present within the folder specified to check for mounting issues within docker.

I can apply this same exact .ico file fine in many other applications I have, but I thought I would try another file to see if it's somehow "non standard". I first used the url from the documentation here. Using the URL works. When downloading that same source .ico locally, with correct permissions, it will not apply.

For reference. the ico file I am trying to use is located here: https://iconarchive.com/download/i103430/paomedia/small-n-flat/house.ico

Here is a screenshot from when it works when a url is provided in settings.yaml, essentially proving that the file can work

image

Steps to reproduce

  1. Download .ico file from: https://iconarchive.com/download/i103430/paomedia/small-n-flat/house.ico
  2. Save file and mount within app filesystem (I use /app/public/images/favicon.ico
  3. Edit settings.yaml to use "favicon: /images/favicon.ico" - save
  4. Reload homepage, and still see the default

then

  1. Edit settings.yaml to use "favicon: https://iconarchive.com/download/i103430/paomedia/small-n-flat/house.ico" - save
  2. Reload homepage, see the .ico in use from url source

homepage version

v0.5.3

Installation method

Docker

Configuration

settings.yaml
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

providers:
  openweathermap: openweathermapapikey
  weatherapi: weatherapiapikey

background: /images/background.jpg
backgroundOpacity: 0.4
favicon: https://iconarchive.com/download/i103430/paomedia/small-n-flat/house.ico

Container Logs

No response

Browser Logs

No response

Other

Until issue #534 is resolved, none of this matters anyway. Any customization of the settings.yaml leads to i18n key names being used for labels.

@TopCheddar27 TopCheddar27 added the bug Something isn't working label Dec 1, 2022
@shamoon
Copy link
Collaborator

shamoon commented Dec 1, 2022

I can confirm but honestly I have no idea why its happening. Maybe something to do with how the docker file manages the /public directory...

@shamoon shamoon added the help wanted Extra attention is needed label Dec 3, 2022
@TopCheddar27
Copy link
Author

I believe I have found the solution, and it relates to closed issue #534 (as I was also experiencing that). I had my image folder directly mounted into the parent (app/public). After reading the solution to that, I changed my mount point to be /app/public/images and just supplying the files within, and now the favicon.ico seems to be applying correctly.

Please confirm on your side, but I believe this can be closed.

@shamoon
Copy link
Collaborator

shamoon commented Dec 4, 2022

Ah yea I meant to circle back on this. I could swear I didn’t do that when I setup a test install for this but anyway, I’m sure if it’s solved for you that’s all it was. Thanks

@shamoon shamoon closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2022
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants