Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Tooltip demos definitions get created only with session profiles #23

Closed
werenall opened this issue Jul 17, 2020 · 0 comments
Closed

Tooltip demos definitions get created only with session profiles #23

werenall opened this issue Jul 17, 2020 · 0 comments

Comments

@werenall
Copy link
Contributor

werenall commented Jul 17, 2020

The DELETEME-demo-tooltip and DELETEME-demo-loading are used in every profile but are defined only with session profiles. We need to make sure that their definitions are added for plain core profile too.

Reproducing steps:

  1. lein new duct foo +cljs +site +hydrogen/core
  2. lein repl
  3. (dev)
  4. (go)

You will see the compiler complain:

----  Compiler Warning on   src/foo/client/home.cljs   line:19  column:5  ----

  Use of undeclared Var foo.client.home/DELETEME-demo-tooltip

  15  (defn main []
  16    [:div
  17     [:img {:src "images/hydrogen-logo-white.svg" :alt "Hydrogen logo"}]
  18     [:h1.demo-greeting "Welcome to Hydrogen!"]
  19     [DELETEME-demo-tooltip]
          ^--- Use of undeclared Var foo.client.home/DELETEME-demo-tooltip
  20     [DELETEME-demo-loading]])
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant