Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Bare hydrogen core project fails at (go) #42

Closed
werenall opened this issue Jun 24, 2021 · 2 comments
Closed

Bare hydrogen core project fails at (go) #42

werenall opened this issue Jun 24, 2021 · 2 comments

Comments

@werenall
Copy link
Contributor

Steps to reproduce:

lein new duct testing-go +cljs +site +hydrogen/core
cd testing-go
lein repl
(dev)
(go)

I get this error:

user=> (dev)
:loaded
dev=> (go)
Execution error (ClassNotFoundException) at jdk.internal.loader.BuiltinClassLoader/loadClass (BuiltinClassLoader.java:583).
com.fasterxml.jackson.core.util.JacksonFeature

I hot-fixed it by adding this dependency to project.clj:
[com.fasterxml.jackson.core/jackson-core "2.12.3"]

How did I know that that's the issue?
lein deps :tree
image

But that shouldn't be necessary to do in product project. This dependency conflict should probably be fixed either in the template or the core module.

@iarenaza
Copy link
Contributor

iarenaza commented Jun 24, 2021

I'm afraid it's broken because base Duct template upgraded the version of duct.module/web, which in turn upgraded to a more recent muuntaja version, that in turn needs a more recent jackson library (because it uses something that is not available in older versions).

But our own Hydrogen duct template cljs-ajax dependency depends on an older version of jackson, and that one happens to be the one chosen by Leiniengen (hence the error).

I have a local commit for that in hydrogen.duct-template. I add a direct dependency for metosin/jsonista v 0.3.3, which is what duct.module/web also expects, and is also what muuntaja also uses. I also add it to be our default JSON manipulation library. It's both faster and more featureful than clojure.data.json and dakrone/cheshire, so I thought it would kill two birds with one stone.

@iarenaza
Copy link
Contributor

Fixed in 6737dd5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants