Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only catch canceled promise #1

Closed
fabiancook opened this issue Jan 8, 2018 · 2 comments
Closed

Only catch canceled promise #1

fabiancook opened this issue Jan 8, 2018 · 2 comments

Comments

@fabiancook
Copy link

fabiancook commented Jan 8, 2018

On this line:

https://github.com/getify/caf/blob/de36fed170aa4e733c2418eaeaaa6bd2f9ca8259/src/caf.src.js#L31

Would it not be beneficial to be able to pick up on the pr errors externally? By catching everything from race would that mean the promise is always going to resolve?

@getify
Copy link
Owner

getify commented Jan 8, 2018

That line doesn't prevent you from listening, it only also listens, to prevent the annoying "unhandled rejection" warnings (in node) if you fail to listen to the rejection.

You can of course (and should!) listen for both resolution and rejection.

@getify
Copy link
Owner

getify commented Jan 9, 2018

Closing for now. Re-open if you have any further concerns.

@getify getify closed this as completed Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants