Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI package? #21

Closed
waxlamp opened this issue Nov 15, 2014 · 18 comments
Closed

PyPI package? #21

waxlamp opened this issue Nov 15, 2014 · 18 comments
Assignees
Labels

Comments

@waxlamp
Copy link

waxlamp commented Nov 15, 2014

Thanks for creating this utility. I was wondering if there are plans to make a python package to PyPI, so that clients can install via tools like pip. That would be pretty great.

@getify
Copy link
Owner

getify commented Nov 15, 2014

I am not a python dev so I have no plans to do so. But almost all translations of this lib to other languages have come from other contributors, and I would happily accept a PR with such a utility, for the benefit of others. <hint, hint> :)

@pradyunsg
Copy link
Contributor

@ronichoudhury This will happen after #23 is completed and closed.

@waxlamp
Copy link
Author

waxlamp commented May 4, 2015

Ah, good news! Thanks again for JSON.minify!

@pradyunsg
Copy link
Contributor

#26 adds all the necessary components for adding the package to PyPI. Expect this issue to be closed soon.

@pradyunsg pradyunsg self-assigned this Jun 15, 2015
@pradyunsg
Copy link
Contributor

Just to annoy everyone with another notification.

@getify Who should be the one publishing the package on PyPI?

@getify
Copy link
Owner

getify commented Sep 1, 2015

I don't do anything in the python world (don't even know really what PyPI is), so it wouldn't be me... someone who's invested in the python community seems like the appropriate party to do so.

@pradyunsg
Copy link
Contributor

@ronichoudhury I'll do this over this weekend.

@getify PyPI - the Python Package Index
Python's npm repository equivalent.

@tobeycarman
Copy link

Any progress on this? I haven't been able to find the package on PyPI.

@pradyunsg
Copy link
Contributor

Nope. I had exams (still do, one tomorrow) so couldn't take out the time.

@tobeycarman
Copy link

Ah, I see. I would be happy take on this issue, but I would need a few hints about how/where to start, as I haven't ever prepared anything for PyPI before and don't really know how it is supposed to work.
Good luck with you exams!

@johanneswilm
Copy link

Hey @pradyunsg how are your exams going? ;-) Could you publish the package now? It seems all other packages with this functionality are totally outdated. it shouldn't take more than a few minutes. Let me know if you cannot do it, then I or someone else will have to push one of the other ones.

@johanneswilm
Copy link

How about you, @PoByBolek? I noticed you were the last one committing a patch to the project. Would you mind doing the PyPi package if no-one else here is willing to do it?

@pradyunsg
Copy link
Contributor

Hey @pradyunsg how are your exams going? ;-)

The hilarious part is - still ongoing.

@pradyunsg
Copy link
Contributor

btw - you can use the current python branch as follows:

pip install git+https://github.com/getify/JSON.minify@python

@johanneswilm
Copy link

Yes, I know. but we need to release, and then we don't want to depend on repo names or even commits on github as they could be gone at any time.

@johanneswilm
Copy link

@getify @pradyunsg As you know, I created and uploaded that package [1] because this issue had not been dealt with for two years. I also added you to pypi to be able to create new releases. From your messages here it sounded like you agreed with this plan. You now changed the readme to say that there is no package on pypi -- what's the point of that? Please, just change the readme back or even better: mention the package on pypi there. You don't really need to do anything other other than changing the readme as it's all set up to work already.

The one change you requested [1], @pradyunsg , sounds like you have a faulty python installation on Windows (?), but you are more than welcome to do that change yourself if you really think it is a good idea.

[1] https://pypi.python.org/pypi/JSON_minify/0.2.1
[2] #43

@pradyunsg
Copy link
Contributor

sounds like you have a faulty python installation on Windows

I don't. I was wanting to do defensive coding. But what you're saying is fine with me. :)

@pradyunsg
Copy link
Contributor

We have this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants