New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add about page #55
Add about page #55
Conversation
Do I need to add styles too? |
I wouldn't worry about any different styles yet... all that will come once we start designing. We do however want some basic markup for the nav, and that markup should be the same in both/all .html files. |
Great. Then I would add nav markup too... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff on index.html has a LOT of changes, mostly formatting related it seems. Are you using an editor plugin/setting that re-formats code?
If so, can you please disable that and reapply your changes to the original file so we're not seeing such an extensive diff of mostly irrelevant changes.
Apparently prettier had automatically formatted the file when I saved it. I just disabled prettier and reformatted both, 'index.html' and 'about.html', files. I tried to follow the formatting style which had been used in original 'index.html' file. I hope it's correct! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty close, but a few changes we need to address, as noted inline.
Thanks for your review and great hints! I just updated the files accordingly. Please check if I have done the innert handling part correctly. |
... it's only used in this one function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making the changes!
Just FYI... gonna hold off merging this because there's another PR that's made some changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
Changes
closes #51
Type of change
Checklist