Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Sticky request in the left menu. #1344

Closed
Lokocr opened this issue Jan 22, 2019 · 9 comments · Fixed by #1471
Closed

[Feature Request] Sticky request in the left menu. #1344

Lokocr opened this issue Jan 22, 2019 · 9 comments · Fixed by #1471
Labels
E-good-first-issue Experience required: Beginner / New

Comments

@Lokocr
Copy link

Lokocr commented Jan 22, 2019

##Add sticky request in top of the left menu.

  • Insomnia Version: 6.3.1
  • Operating System: Linux Mate (Ubuntu 18.04.1 LTS)

Details

I think it should be a good idea to have some sticky request, for example, when you have a important request like Token generator for authentication but are you have more than 30 other request saved in the request menu (left one in the UI).

image

I could be store in the same menu but with a flag or somthing like that, something that make a difference look from the other ones.

@welcome
Copy link

welcome bot commented Jan 22, 2019

👋 Thanks for opening your first issue! If you're reporting a 🐞 bug, please make sure
you include steps to reproduce it. If you're requesting a feature 🎁, please provide real
use cases that would benefit. 👪

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@gschier
Copy link
Contributor

gschier commented Jan 29, 2019

Yes! This one has been in the back of my head for a while now. Essentially, the ability to pin requests (a common feature in many apps).

Also, it looks like you'd benefit from putting some of those in folders 😆🙃

@gschier gschier added E-good-first-issue Experience required: Beginner / New Accepted labels Feb 1, 2019
@viktree
Copy link

viktree commented Feb 15, 2019

@gschier Never contributed to open source before, but I use insomnia every day and would definitely find value in this feature valuable. I would love to take a crack at it this, if that is okay.

@gschier
Copy link
Contributor

gschier commented Mar 7, 2019

@viktree it's definitely okay if you want to try 😃

@olearycrew
Copy link

@viktree are you still looking to do this? I was also considering it 😄

@viktree
Copy link

viktree commented Apr 8, 2019

@brendano86 Kinda left this for a little while. Have at it 😄

@develohpanda
Copy link
Contributor

@brendano86 any progress from your end? Otherwise I will pick this up.

@develohpanda
Copy link
Contributor

@gschier I've started on this and my approach (for both request and request group) is to:

  1. Create a Pin/Unpin option in the action menu dropdown
  2. Show section identical to the sidebar-list between the filter and sidebar-list, for pinned items (hidden if no pinned items)
  3. Show a fa-thumb-tack on pinned items

I'm yet to figure out sizing constraints for the pinned rows and all rows, but will make sure they are easy to differentiate. This is the only way I could think of having sticky/pinned items that stay at the top while the rest of the section scrolls.

Am I on the right track?

@gschier
Copy link
Contributor

gschier commented Apr 25, 2019

It sounds like you're on the right track @develohpanda 😄

If you want some early feedback feel free to create a PR with what you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-good-first-issue Experience required: Beginner / New
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants