New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Exporting the workspace / all workspaces as HAR file #523

Merged
merged 3 commits into from Nov 1, 2017

Conversation

Projects
None yet
2 participants
@Atvaark
Contributor

Atvaark commented Oct 12, 2017

This PR adds a the option to export the requests in a workspace (or all workspaces) as an HAR (HTTP Archive 1.2) file.

See: #416

Exporting as .har is implemented.
Exporting single har requests still works as it looks (the code generator).
I'm currently testing the output in different tools (e. g. Fiddler or HTTPolice) to check for any issues.

Closes #416

@Atvaark Atvaark changed the title from WIP: Implemented exporting the workspace / all workspaces as HAR file to WIP: Exporting the workspace / all workspaces as HAR file Oct 12, 2017

@gschier

This comment has been minimized.

Collaborator

gschier commented Oct 12, 2017

Thanks for this @Atvaark! I'll try and get to reviewing/merging this tomorrow.

@gschier

Hey @Atvaark. I just took a look at this and it looks great. However, since the code has quite a bit of complexity, it would be nice to see some tests around exportHarResponse as well as at least one test for exportHar to make sure nothing breaks in the future.

The current tests you touched in this PR should be a good starting point, but let me know if you need/want any additional guidance. 😄

}
export async function getLatestForRequest (requestId: string) {
export async function getLatestForRequest (requestId: string): Response | null {

This comment has been minimized.

@gschier

gschier Oct 13, 2017

Collaborator

Minor, but this should return Promise<Response | null>.

@Atvaark Atvaark force-pushed the Atvaark:har-export branch from 4f47bd8 to 4a07794 Oct 13, 2017

@Atvaark Atvaark force-pushed the Atvaark:har-export branch from 4752a87 to 0d05c40 Oct 15, 2017

@Atvaark

This comment has been minimized.

Contributor

Atvaark commented Oct 16, 2017

Hey @gschier,
I added a couple of tests. Please take a look at them in case I missed something.

@gschier

This comment has been minimized.

Collaborator

gschier commented Oct 16, 2017

Thanks, I will try to take a look today.

@gschier

This comment has been minimized.

Collaborator

gschier commented Oct 27, 2017

Sorry for the delay @Atvaark. I was without a computer for the last two weeks because my keyboard broke. I have this on my list of to-dos for next week, though. 😄

@gschier

gschier approved these changes Nov 1, 2017

This looks good! Going to merge it in and make a few small tweaks to help it match the codebase conventions a bit closer. I'll be including it in this week's release.

Thanks for the PR!

@gschier gschier merged commit f6d00d3 into getinsomnia:develop Nov 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment