New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Exporting the workspace / all workspaces as HAR file #523
Conversation
Thanks for this @Atvaark! I'll try and get to reviewing/merging this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Atvaark. I just took a look at this and it looks great. However, since the code has quite a bit of complexity, it would be nice to see some tests around exportHarResponse
as well as at least one test for exportHar
to make sure nothing breaks in the future.
The current tests you touched in this PR should be a good starting point, but let me know if you need/want any additional guidance. 😄
app/models/response.js
Outdated
} | ||
|
||
export async function getLatestForRequest (requestId: string) { | ||
export async function getLatestForRequest (requestId: string): Response | null { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but this should return Promise<Response | null>
.
Hey @gschier, |
Thanks, I will try to take a look today. |
Sorry for the delay @Atvaark. I was without a computer for the last two weeks because my keyboard broke. I have this on my list of to-dos for next week, though. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Going to merge it in and make a few small tweaks to help it match the codebase conventions a bit closer. I'll be including it in this week's release.
Thanks for the PR!
* Implemented exporting the workspace / all workspaces as HAR file * Added HAR export unit tests
This PR adds a the option to export the requests in a workspace (or all workspaces) as an HAR (HTTP Archive 1.2) file.
See: #416
Exporting as .har is implemented.
Exporting single har requests still works as it looks (the code generator).
I'm currently testing the output in different tools (e. g. Fiddler or HTTPolice) to check for any issues.
Closes #416