Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dir::copy recursive not honoring $ignore #3243

Closed
iskrisis opened this issue Apr 13, 2021 · 1 comment · Fixed by #3269
Closed

Dir::copy recursive not honoring $ignore #3243

iskrisis opened this issue Apr 13, 2021 · 1 comment · Fixed by #3269
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone

Comments

@iskrisis
Copy link

When using Dir::copy in recursive mode the $ignore option is lost after first recursion. I am not sure this is not intentional for some performance reasons but it makes that function pretty unpredictable.

It's this line

static::copy($root, $target . '/' . $name);

Expected behavior
I would expect $ignore to function everywhere. Fix is simply passing the ignore into the recursion aswell.

static::copy($root, $target . '/' . $name, true, $ignore);
@lukasbestle lukasbestle added this to the 3.5.x milestone Apr 13, 2021
@bastianallgeier bastianallgeier modified the milestones: 3.5.x, 3.5.5 Apr 27, 2021
@bastianallgeier bastianallgeier linked a pull request Apr 27, 2021 that will close this issue
4 tasks
@bastianallgeier
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants