Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] Field value is empty on chrome autofill #4312

Closed
wdebusschere opened this issue May 20, 2022 · 7 comments
Closed

[Panel] Field value is empty on chrome autofill #4312

wdebusschere opened this issue May 20, 2022 · 7 comments
Labels
needs: discussion 🗣 Requires further discussion to proceed type: bug 🐛 Is a bug; fixes a bug

Comments

@wdebusschere
Copy link

Description

I have some fields with names that trigger the Google chrome browser to autocomplete them.
Example City, I can select the city suggested by the chrome browser, but because i’m not actually typing it, it is not saved…
The character count stays on 0.
It only saves when i click again on the selected value.

It also shows the character count is 0.
I guess the input event has to be tuned in the javascript.

(I have also tested it with Safari, but there it works)

Expected behavior
Data entered by the browser autocomplete mechanism should be saved.

Screenshots
image
image

To reproduce

Startkit->Panel->Edit a user
Fill in the city or zip with chrome autocomplete

Your setup

Kirby Version
Starterkit

Your system (please complete the following information)

  • Browser: Chrome Version 101.0.4951.64 (Official Build) (x86_64)
@wdebusschere wdebusschere changed the title Field value is empty on chrome autofill [Panel] Field value is empty on chrome autofill May 20, 2022
@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label May 20, 2022
@afbora
Copy link
Member

afbora commented May 20, 2022

To team

You can follow the related issue in the Vue repository vuejs/vue#7058. It's a bug but I'm not sure if it's an issue we can fix 🤔

I also don't understand why autofill works even though autocomplete is false or off. Could it be a browser bug?

Few links about that:

@afbora afbora added the needs: discussion 🗣 Requires further discussion to proceed label May 20, 2022
@lukasbestle
Copy link
Member

lukasbestle commented May 20, 2022

Since we use a <form>, can we use the onchange event to get notified of changes to the inputs?

@distantnative
Copy link
Member

@lukasbestle Based on the discussion @afbora linked I understood this wouldn't work but just more complicated hacks?

@lukasbestle
Copy link
Member

Yeah, doesn't seem to be 100 % reliable. Maybe it can at least help us most of the time (better than the status quo).

I'd really like to avoid an interval-based hack (too much wasted processing just for this). Not sure about the other suggestions, maybe one of them can work for us.

@wdebusschere
Copy link
Author

Could this be a solution? add "name" attribute.
https://lifesaver.codes/answer/chrome-autofill-does-not-trigger-change-7058

@afbora
Copy link
Member

afbora commented May 21, 2022

@wdebusschere This already referenced the link I posted first.

I've created a working code sample for you to play with. But I still couldn't find a solution.

https://jsfiddle.net/byybora/ugoevzf4/

@afbora
Copy link
Member

afbora commented Aug 11, 2022

I'm closing this issue because of this is definitely just a browser-specific bug and vuejs team already marked the related issue as browser quirks.

@afbora afbora closed this as completed Aug 11, 2022
@lukasbestle lukasbestle closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: discussion 🗣 Requires further discussion to proceed type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

No branches or pull requests

4 participants