Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel] Tweak breakpoints for many tabs (label disappearing) #523

Closed
vauvarin opened this issue Jun 26, 2018 · 3 comments
Closed

[Panel] Tweak breakpoints for many tabs (label disappearing) #523

vauvarin opened this issue Jun 26, 2018 · 3 comments
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Milestone

Comments

@vauvarin
Copy link

vauvarin commented Jun 26, 2018

When you add more than four tabs, label disappears on the tabs which are not the current tab.

tabs

The blueprint:

title: Site

tabs:
  pages:
    label:
      en: Pages
      de: Seiten
    icon: page
    columns:
      - 1/1: kitchensink
      - 1/1: playground
  footer:
    label: Footer
    icon: twitter
    columns:
      - 1/1: footer
  seo:
    label: SEO
    icon: search
    columns:
      - 2/3: seoContent
      - 1/3: seoImages
  taxonomy:
    label: Taxonomy
    icon: tag
    columns:
      - 1/1: tags
  test:
    label: Test
    icon: tag
    columns:
      - 1/1: mytest

sections:

  
  # TEST TAB
  mytest:
    type: fields
    fields:
      tags:
        label: Name
        type: text

  # PAGES TAB
  kitchensink:
    headline: Examples
    type: pages
    status: listed
    item:
      image: false
      info: "{{ page.template }}"

  playground:
    headline: Playground
    type: pages
    status: unlisted
    templates:
      - form
      - sandbox


  # FOOTER TAB
  footer:
    type: fields
    fields:
      copyright:
        label: Copyright
        type: text
        before: ©
      twitter:
        label: Twitter Account
        type: text
        icon: twitter
        width: 1/2
        before: "@"
      instagram:
        label: Instagram Account
        type: text
        icon: instagram
        width: 1/2

  # SEO TAB
  seoContent:
    type: fields
    fields:
      metaTitle:
        label: Meta Title
        type: text
        required: true
      metaDescription:
        label: Meta Description
        type: textarea
        buttons: false

  seoImages:
    type: files
    headline: Seo Images
    min: 1

  # TAXONOMY TAB
  tags:
    type: fields
    fields:
      tags:
        label: Tags
        type: structure
        fields:
          name:
            label: Tag
            type: text
            width: 1/2
          value:
            label: Value
            type: text
            width: 1/2
@bastianallgeier
Copy link
Member

That is an intended behavior for more than 4 tabs. But I think we will need to tweak the breakpoints for this. The background is that it's really hard to make room for all the tabs otherwise and we don't want to throw too much js on it to solve that.

@distantnative distantnative added this to the Beta 2 milestone Jun 30, 2018
@distantnative distantnative changed the title Label disappears on tabs if we add more than 4 tabs [Panel] Tweak breakpoints for many tabs (label disappearing) Jun 30, 2018
@distantnative
Copy link
Member

@bastianallgeier has this been solved with your recent JS logic update?

@bastianallgeier
Copy link
Member

@distantnative yep :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

No branches or pull requests

3 participants