Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled toggle field in object preview can still be changed #6346

Closed
bvdputte opened this issue Mar 15, 2024 · 1 comment · Fixed by #6361
Closed

Disabled toggle field in object preview can still be changed #6346

bvdputte opened this issue Mar 15, 2024 · 1 comment · Fixed by #6361
Assignees
Labels
type: bug 🐛 Is a bug; fixes a bug type: enhancement ✨ Suggests an enhancement; improves Kirby
Milestone

Comments

@bvdputte
Copy link

Description

When you have a toggle field in an object field with disabled: true, you can still change it from the object preview.

Expected behavior
That this field would've been disabled there too.

Your setup

Kirby Version
4.1.1

Your system (please complete the following information)

  • Device: Macbook Pro
  • OS: macOS
  • Browser: N/A
@distantnative
Copy link
Member

Currently, the field previews are trying to implement inline editing no matter what. I think each field preview needs a prop that defines whether it's editable or not. We should expose this prop through columns definitions etc. but also ensure to automatically set it to false, e.g. when a field is disabled.

@distantnative distantnative added type: enhancement ✨ Suggests an enhancement; improves Kirby type: bug 🐛 Is a bug; fixes a bug labels Mar 23, 2024
@distantnative distantnative self-assigned this Mar 23, 2024
@distantnative distantnative added this to the 4.2.0 milestone Mar 23, 2024
@distantnative distantnative linked a pull request Mar 24, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants