Skip to content
This repository has been archived by the owner on Jan 25, 2021. It is now read-only.

Error message when trying to update page if panel.page.visibility set to false in role permissions. #989

Closed
texnixe opened this issue Jan 12, 2017 · 4 comments
Labels
Milestone

Comments

@texnixe
Copy link

texnixe commented Jan 12, 2017

https://forum.getkirby.com/t/role-permission-i-e-panel-page-visibility/6230/20

Changes are saved to file in spite of the error message, though.

@texnixe texnixe added the bug label Jan 12, 2017
@Mattrushka
Copy link

I guess this related?!?

Behaviour
When I specify that
a) a certain user-role can update specific templates
b) disallow the user to change visibility

'panel.page.update' => function() {
      return $this->target()->page()->template() === 'mytemplate';
 },
panel.page.visibility => false

the user is not able to edit the template anymore but changes are saved anyway.
And I would not expect that panel.page.visibility => false overrides the 'panel.page.update' functionality because this means that I cannot have both settings together.

@samuba
Copy link

samuba commented Dec 13, 2017

No intentions to fix this? It's pretty ugly because there are only two solutions, that I see, right now:

  • setting panel.page.visibility to true for users that should not have that permission
  • leaving users with the very irritating popup

@lukasbestle
Copy link
Member

We always have the intention to fix bugs. It's just that we can't fix all of them. :)
But I will take a look at it. Maybe it's a typo in the code somewhere.

@lukasbestle lukasbestle added this to the 2.5.9 milestone Dec 21, 2017
@lukasbestle
Copy link
Member

Unfortunately I can't find a simple fix. We will however rewrite the permissions feature in Kirby 3, which will probably fix this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants