Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubsamplingScaleImage Exception #97

Open
atavism opened this issue May 23, 2015 · 2 comments
Open

SubsamplingScaleImage Exception #97

atavism opened this issue May 23, 2015 · 2 comments
Labels

Comments

@atavism
Copy link

atavism commented May 23, 2015

Reported by Crashlytics

java.lang.NullPointerException: imageSource must not be null
       at com.davemorrissey.labs.subscaleview.SubsamplingScaleImageView.setImage(SubsamplingScaleImageView.java:346)
       at com.davemorrissey.labs.subscaleview.SubsamplingScaleImageView.setImage(SubsamplingScaleImageView.java:303)
       at org.getlantern.firetweet.activity.support.MediaViewerActivity$ImagePageFragment.onLoadFinished(MediaViewerActivity.java:414)
       at org.getlantern.firetweet.activity.support.MediaViewerActivity$ImagePageFragment.onLoadFinished(MediaViewerActivity.java:354)
       at android.support.v4.app.LoaderManagerImpl$LoaderInfo.callOnLoadFinished(LoaderManager.java:427)
       at android.support.v4.app.LoaderManagerImpl$LoaderInfo.onLoadComplete(LoaderManager.java:395)
       at android.support.v4.content.Loader.deliverResult(Loader.java:104)
       at android.support.v4.content.AsyncTaskLoader.dispatchOnLoadComplete(AsyncTaskLoader.java:223)
       at android.support.v4.content.AsyncTaskLoader$LoadTask.onPostExecute(AsyncTaskLoader.java:61)
       at android.support.v4.content.ModernAsyncTask.finish(ModernAsyncTask.java:461)
       at android.support.v4.content.ModernAsyncTask.access$500(ModernAsyncTask.java:47)
       at android.support.v4.content.ModernAsyncTask$InternalHandler.handleMessage(ModernAsyncTask.java:474)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:136)
       at android.app.ActivityThread.main(ActivityThread.java:5032)
       at java.lang.reflect.Method.invokeNative(Method.java)
       at java.lang.reflect.Method.invoke(Method.java:515)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
       at dalvik.system.NativeStart.main(NativeStart.java)
@atavism atavism added the P1 label May 23, 2015
@atavism
Copy link
Author

atavism commented May 23, 2015

Awesome, thanks for investigating this further. It looks like we're actually setting the image to null in the code in this scenario too (line 414 in MediaViewerActivity.java). This doesn't actually cause the app to crash but just shows an error message, correct? If so, that's probably the right behavior then.

@myleshorton
Copy link
Contributor

Is this one resolved @atavism?

@getlantern getlantern deleted a comment from fffw Mar 1, 2021
@getlantern getlantern deleted a comment from fffw Mar 1, 2021
@getlantern getlantern deleted a comment from fffw Mar 1, 2021
@getlantern getlantern deleted a comment from myleshorton Mar 1, 2021
@getlantern getlantern deleted a comment from fffw Mar 1, 2021
@getlantern getlantern deleted a comment from atavism Mar 1, 2021
@getlantern getlantern deleted a comment from teamlantern Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants