Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .DS_Store on s3 sync #346

Open
ktwbc opened this issue Jul 9, 2023 · 1 comment
Open

Ignore .DS_Store on s3 sync #346

ktwbc opened this issue Jul 9, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ktwbc
Copy link

ktwbc commented Jul 9, 2023

Start from the Use-case

When using the single-page-app construct on MacOS to deploy from the local folder to S3, if there are any .DS_Store files in the folder as a result of simply going into that folder with Finder, those files are uploaded to S3 too.

There is no reason to sync os-specific files like this. There doesn't appear to be a way to exclude files via a pattern either with this construct. There should be some inherent blacklist for these types of files.

Example Config

No response

Implementation Idea

No response

@ktwbc ktwbc added the enhancement New feature or request label Jul 9, 2023
@mnapoli
Copy link
Member

mnapoli commented Jul 11, 2023

Agreed, I think having this automatically excluded would make sense. Feel free to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants