Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All titles on items are "..." and search does not work[Bug Report] #34

Closed
ameel opened this issue May 7, 2020 · 10 comments
Closed

All titles on items are "..." and search does not work[Bug Report] #34

ameel opened this issue May 7, 2020 · 10 comments
Labels
bug Something isn't working

Comments

@ameel
Copy link

ameel commented May 7, 2020

All titles on items show "...". Hovering over the "..." for an item shows title as tooltip.
Search functionality does not appear to be working at all.

edit:
Issue is present on both latest release and latest build from source.
edit2:
Note the titles on the items show up when a folder containing lots of items is being loaded, and then disappears right after.
edit3:
e.g of output html for an item:
<div class="item uk-first-column" data-mtime="1588786511" data-progress="0.0"> <a class="acard" href="/book/0f11efc0ab1b49c7ac0af693e784aac0"> <div class="uk-card uk-card-default"> <div class="uk-card-media-top"> <img data-src="/api/page/0f11efc0ab1b49c7ac0af693e784aac0/b88dbc0e72dc4b84a601b515860d8655/1" data-width="" data-height="" alt="" uk-img="" src="http://192.168.0.3:9000/api/page/0f11efc0ab1b49c7ac0af693e784aac0/b88dbc0e72dc4b84a601b515860d8655/1"> </div> <div class="uk-card-body"> <h3 class="uk-card-title break-word ddd-truncated" data-title="Test" uk-tooltip="Test" title="" aria-expanded="false">… </h3> <p>21 entries</p> </div> </div> </a> </div>

@ameel ameel added the bug Something isn't working label May 7, 2020
@ameel ameel changed the title All titles are "..." and search does not work[Bug Report] All titles on items are "..." and search does not work[Bug Report] May 7, 2020
@hkalexling
Copy link
Member

Thanks for the bug report.

This looks like #26. If you used an older version of Mango (pre v0.2.4) and recently updated it to the latest version, please try to clear the browser cache and data. If the problem persists, please try to use the incognito mode or a different browser to isolate the problem.

About the search functionality, do you see any error messages in the browser console?

@ameel
Copy link
Author

ameel commented May 7, 2020

Thanks for the reply. I only installed latest version and latest beta yesterday. I never installed or ran Mango once before.
The "..." title issue is present in Chrome on Windows 10, including incognito mode.
On Microsoft Edge on Windows 10, there is no such issue.
On chrome on Android, there is no such issue.
On firefox on ubuntu, there is no such issue.

In relation to search function:
On Chrome on Windows 10, functionality does not work at all. Results are empty. There are no errors in console.
On Microsoft Edge on Windows 10, functionality works and search gives results.
On Chrome on Android, functionality works and search gives results.
On firefox on ubuntu, functionality works and search gives results.

I can't get chrome on Windows 10 to work at all. There's a chance the "..." title issue and search issue may be related.

@ameel
Copy link
Author

ameel commented May 7, 2020

Update:
Issue present on Chrome 81.0.4044.129 on Windows 10. Updated Chrome to 81.0.4044.138. Issue persists.

Tested on other devices, and no issues on:
Chrome 81.0.4044.129 on Windows 10 on a different device
Microsoft Edge on Windows 10 on ORIGINAL DEVICE
Chrome on Android phone
Firefox on Ubunt

@hkalexling
Copy link
Member

hkalexling commented May 8, 2020

Wow, thanks for all the testings!

This issue is challenging because it's difficult to reproduce and pinpoint the cause. Similar issues have been reported a few times, and I have tested it in multiple versions of Chrome on different devices/systems but I can never reproduce it.

The title truncation should only happen to long titles. It's a new feature added in v0.2.4 to make the layout cleaner (see #23 and v0.2.4 release note). Since it's causing problems, I think I will add an option in the config file to disable it.

I will work on a new release for this, and it would be great if you could help to test in on that particular device.

@hkalexling
Copy link
Member

Please try the followings and see if they resolve the problem

  1. Resizing the browser window to trigger a JS update
  2. Clear site data. You can do this by launching the Chrome developer tools -> application tab -> clear storage -> check all boxes and click "Clear site data"

clear-data

Thanks!

@ameel
Copy link
Author

ameel commented May 9, 2020

Hey Alex,

Thank you for your reply. I tried your recommendations, but no changes. The issues persist. Is there anything else you would like me to try? Happy to have a screen-sharing session if you'd like to try anything else out.

I note the following console error on login, but this error is present on other systems/devices too.
Chrome on Win10 (title issue + search function not working):
Uncaught SyntaxError: Unexpected token '<' login:38 Uncaught ReferenceError: setTheme is not defined at login:38 (anonymous) @ login:38

Firefox (everything works fine):
SyntaxError: expected expression, got '<' theme.js:1 ReferenceError: setTheme is not definedlogin:38:3 <anonymous> http://192.168.0.3:9000/login:38

@ameel
Copy link
Author

ameel commented May 10, 2020

btw, which code triggers JS update on resize?

@hkalexling
Copy link
Member

hkalexling commented May 10, 2020

btw, which code triggers JS update on resize?

The title truncation is handled by the dotdotdot library. When initializing it, I passed in watch (see public/js/dots.js#L5) and it's supposed to re-apply the truncation when the content size changes. I was hoping that this would correct the incorrect truncation.

I guess the library has some weird bug on Chrome, and when it happens, it somehow blocks the other scripts from executing and therefore affects searching and sorting.

@hkalexling
Copy link
Member

Hi @ameel, sorry for the long delay. I have been terribly busy this week.

Could you please try v0.3.1-alpha and add disable_ellipsis_truncation: true to your config file? This applies the truncation without using the dotdotdot library I mentioned above and should resolve the issue. It would be great if you could test if the searching/sorting functionalities are working as expected after the changes.

PS: Clearing cache might be needed for the updated CSS file to take effect.

Thanks!

@hkalexling
Copy link
Member

Closing for inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants