Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work if DefaultBuildSettings is not set to BuildSettingsVersion.V2 #52

Closed
sorab2142 opened this issue Aug 1, 2020 · 2 comments

Comments

@sorab2142
Copy link

I am upgrading a project from UE 4.22 to 4.25 and if I dont use the following:
DefaultBuildSettings = BuildSettingsVersion.V2;
because I would need to update all legacy paths (#includes)

Your plugin throws a compile error:
BLUI\Source\Blu\Public\RenderHandler.h(3): fatal error C1083: Cannot open include file: 'CEFInclude.h': No such file or directory

Why is this file in a Private directory? And how do I compile without that flag on?

@getnamo
Copy link
Owner

getnamo commented Aug 2, 2020

That setting should just force IWYU with stricter settings. I'm not sure if moving it to public solves it, but that change seems harmless so I pushed it here: 94e04b3

While I do have build settings v2 enabled, I might not be using the class in C++ which could cause the build error. Let me know if the minor change resolves it.

@sorab2142
Copy link
Author

Thanks @getnamo that fixes it.

@getnamo getnamo closed this as completed Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants