Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow native callbacks not on game thread #113

Closed
getnamo opened this issue Mar 28, 2019 · 3 comments
Closed

Allow native callbacks not on game thread #113

getnamo opened this issue Mar 28, 2019 · 3 comments
Labels
addressed awaiting release enhancement

Comments

@getnamo
Copy link
Owner

getnamo commented Mar 28, 2019 •
edited
Loading

FSocketIONative only.

Boolean toggle.

Currently forces gamethread callback.

https://github.com/getnamo/socketio-client-ue4/blob/master/Source/SocketIOClient/Private/SocketIONative.cpp#L213

There may be cases where user would want to handle an event on own thread.
@getnamo
Copy link
Owner Author

getnamo commented Aug 7, 2019

feature work branch: https://github.com/getnamo/socketio-client-ue4/tree/issue-113

@getnamo
Copy link
Owner Author

getnamo commented Aug 7, 2019 •
edited
Loading

merged to unstable in 4308442. Awaiting other bugfixes before release.

Had the added benefit of removing threading logic from USocketioClientComponent.

@getnamo
Copy link
Owner Author

getnamo commented Sep 12, 2019

Released in https://github.com/getnamo/socketio-client-ue4/releases/tag/v1.1.0

Note: 4.23 version only seems to block this feature

@getnamo getnamo closed this as completed Sep 12, 2019
@getnamo getnamo mentioned this issue Nov 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addressed awaiting release enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@getnamo