Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overloaded Emit with TEXT() as second parameter #140

Closed
getnamo opened this issue Aug 1, 2019 · 2 comments
Closed

Overloaded Emit with TEXT() as second parameter #140

getnamo opened this issue Aug 1, 2019 · 2 comments
Labels
addressed awaiting release enhancement

Comments

@getnamo
Copy link
Owner

getnamo commented Aug 1, 2019

Right now if you do e.g. Socket->Emit(TEXT("MyEvent"), TEXT("hi")); in FSocketIONative it will default to bool parameter, which is incorrect.
@getnamo
Copy link
Owner Author

getnamo commented Aug 1, 2019 •
edited
Loading

added support for this in be484fe

Required a macro to handle the two possible text types wchar_t and char16_t for windows/non-windows platforms.

Will land in 1.1.0

@getnamo getnamo changed the title Overloaded EMIT with TEXT() as second parameter Overloaded Emit with TEXT() as second parameter Aug 1, 2019
@getnamo getnamo mentioned this issue Aug 1, 2019
Closed
@getnamo
Copy link
Owner Author

getnamo commented Sep 12, 2019

Released in https://github.com/getnamo/socketio-client-ue4/releases/tag/v1.1.0

@getnamo getnamo closed this as completed Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addressed awaiting release enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@getnamo