feat: integrate roku-dev #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchelkowski
requested review from
adamczopek and
shirishapitta
and removed request for
a team
bchelkowski
force-pushed
the
feat--integrate-roku-dev
branch
from
b53e7e3
to
310a4b2
Compare
bchelkowski
force-pushed
the
feat--integrate-roku-dev
branch
from
310a4b2
to
f7c9388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes: #66
roku-devleads to removing obsoleterequestandrequest-promisepackages.kopytko-packagerwork for nodejs versions >=19How did you implement it:
Used
roku-devpackage instead ofrequestandrequest-promise.How can we verify it:
Every script should work as it was working before.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO